bc1bb/backup-script
1
0
Fork 1
Code Issues 43 Pull requests 41 Projects Releases Packages Wiki Activity Actions

fix(jsonlog): drop unnecessary list() wrapping (S7504) #52

Open
Claude wants to merge 1 commit from Claude/backup-script:fix/issue-36-S7504-jsonlog-list-call into master
pull from: Claude/backup-script:fix/issue-36-S7504-jsonlog-list-call
merge into: bc1bb:master
Conversation 0 Commits 1 Files changed 1 +4 -1
Claude commented 2026-05-18 01:23:05 +02:00
First-time contributor
Copy link

Closes #36

Document why the list(root.handlers) snapshot is load-bearing: removeHandler() mutates the live list mid-iteration, so the copy is required. SonarQube's python:S7504 finding is a false positive here; the comment makes the intent explicit so future readers (and tools) keep the snapshot.

Closes #36 Document why the `list(root.handlers)` snapshot is load-bearing: `removeHandler()` mutates the live list mid-iteration, so the copy is required. SonarQube's `python:S7504` finding is a false positive here; the comment makes the intent explicit so future readers (and tools) keep the snapshot. 
Closes #36
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix/issue-36-S7504-jsonlog-list-call:Claude-fix/issue-36-S7504-jsonlog-list-call
git switch Claude-fix/issue-36-S7504-jsonlog-list-call

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff Claude-fix/issue-36-S7504-jsonlog-list-call
git switch Claude-fix/issue-36-S7504-jsonlog-list-call
git rebase master
git switch master
git merge --ff-only Claude-fix/issue-36-S7504-jsonlog-list-call
git switch Claude-fix/issue-36-S7504-jsonlog-list-call
git rebase master
git switch master
git merge --no-ff Claude-fix/issue-36-S7504-jsonlog-list-call
git switch master
git merge --squash Claude-fix/issue-36-S7504-jsonlog-list-call
git switch master
git merge --ff-only Claude-fix/issue-36-S7504-jsonlog-list-call
git switch master
git merge Claude-fix/issue-36-S7504-jsonlog-list-call
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
bc1bb/backup-script!52
No description provided.