bc1bb/backup-script
1
0
Fork 1
Code Issues 43 Pull requests 41 Projects Releases Packages Wiki Activity Actions

fix(planner): drop unused dest_name/dest from _build_docker_jobs (S1172) #61

Open
Claude wants to merge 1 commit from Claude/backup-script:fix/issues-27-28-S1172-planner-docker-jobs-unused-params into master
pull from: Claude/backup-script:fix/issues-27-28-S1172-planner-docker-jobs-unused-params
merge into: bc1bb:master
Conversation 0 Commits 1 Files changed 1 +2 -2
Claude commented 2026-05-18 01:24:36 +02:00
First-time contributor
Copy link

Closes #27
Closes #28

dest_name and dest are declared on Planner._build_docker_jobs but
never used inside the body — the method only reads
self._config.categories.docker and calls the (stub) docker discovery.
SonarQube flagged both parameters as python:S1172
(unused method parameter).

This PR drops both parameters from the signature and updates the single
call site in Planner._build_jobs_for_category (in the cat_name == "docker" branch) to call self._build_docker_jobs() with no
arguments. The rest of the planner — including the per-category
critical-flag heuristic in _is_critical(...) — is unaffected because
the docker category was never wired into it (it's always non-critical
today).

Both issues are addressed in a single PR because they touch the same
def line and the same single call site — splitting them would
require interleaving two commits that each leave the file in a
broken/inconsistent state. Treat as a paired fix.

Closes #27 Closes #28 `dest_name` and `dest` are declared on `Planner._build_docker_jobs` but never used inside the body — the method only reads `self._config.categories.docker` and calls the (stub) docker discovery. SonarQube flagged both parameters as `python:S1172` (unused method parameter). This PR drops both parameters from the signature and updates the single call site in `Planner._build_jobs_for_category` (in the `cat_name == "docker"` branch) to call `self._build_docker_jobs()` with no arguments. The rest of the planner — including the per-category critical-flag heuristic in `_is_critical(...)` — is unaffected because the `docker` category was never wired into it (it's always non-critical today). Both issues are addressed in a single PR because they touch the same `def` line and the same single call site — splitting them would require interleaving two commits that each leave the file in a broken/inconsistent state. Treat as a paired fix. 
`_build_docker_jobs` never touched `dest_name` or `dest` — the body only
reads `self._config.categories.docker` and calls the docker discovery
stub. Drop both parameters and update the single caller in
`_build_jobs_for_category`.

Closes #27
Closes #28
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix/issues-27-28-S1172-planner-docker-jobs-unused-params:Claude-fix/issues-27-28-S1172-planner-docker-jobs-unused-params
git switch Claude-fix/issues-27-28-S1172-planner-docker-jobs-unused-params

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff Claude-fix/issues-27-28-S1172-planner-docker-jobs-unused-params
git switch Claude-fix/issues-27-28-S1172-planner-docker-jobs-unused-params
git rebase master
git switch master
git merge --ff-only Claude-fix/issues-27-28-S1172-planner-docker-jobs-unused-params
git switch Claude-fix/issues-27-28-S1172-planner-docker-jobs-unused-params
git rebase master
git switch master
git merge --no-ff Claude-fix/issues-27-28-S1172-planner-docker-jobs-unused-params
git switch master
git merge --squash Claude-fix/issues-27-28-S1172-planner-docker-jobs-unused-params
git switch master
git merge --ff-only Claude-fix/issues-27-28-S1172-planner-docker-jobs-unused-params
git switch master
git merge Claude-fix/issues-27-28-S1172-planner-docker-jobs-unused-params
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
bc1bb/backup-script!61
No description provided.